Add custom JSON mode generation option for Gemini language model #80
+94
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds JSON mode support for Gemini language models, enabling structured JSON output generation. The implementation introduces a new JSONMode enum with three states: disabled, enabled (basic JSON), and schema-constrained JSON output.
Key changes:
- Added a
JSONModeenum toCustomGenerationOptionswith support for basic JSON mode and schema-based JSON output - Integrated JSON mode configuration into the Gemini API request generation logic by setting
responseMimeTypeand optionallyresponseSchema - Added comprehensive test coverage for both basic JSON mode and schema-constrained JSON mode
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/AnyLanguageModel/Models/GeminiLanguageModel.swift | Implements the JSONMode enum and integrates it into the request generation logic, setting the appropriate Gemini API parameters |
| Tests/AnyLanguageModelTests/GeminiLanguageModelTests.swift | Adds tests for JSON mode functionality, including basic JSON mode and schema-constrained mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79